Skip to content

test(updater): treat GitHub 429 secondary rate limits as skip, not failure #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
Jul 27, 2026
Merged

test(updater): treat GitHub 429 secondary rate limits as skip, not failure #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion attestation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,20 @@ func TestRealVerify_EndToEnd_v1_12_5(t *testing.T) {
}
}

// isRateLimited reports whether err is GitHub throttling us rather than a
// genuine verification failure. Unauthenticated callers get two distinct
// responses: 403 for the plain hourly rate limit, and 429 for secondary
// ("abuse detection") limits. The 429 body says "abuse detection mechanism"
// and only ever spells the phrase hyphenated ("abuse-rate-limits"), so
// neither of the original patterns matched it and the test hard-failed.
func isRateLimited(err error) bool {
return err != nil && (containsAny(err.Error(), "returned 403", "rate limit"))
return err != nil && containsAny(err.Error(),
"returned 403",
"returned 429",
"rate limit",
"rate-limit",
"abuse detection",
)
}

func containsAny(s string, subs ...string) bool {
Expand Down