fix: read iCalendar from stdin when not a terminal#6
Open
cradnovich wants to merge 1 commit into
Open
Conversation
items create and events create now detect whether stdin is a terminal.
When piped (non-TTY), they read iCalendar content directly from stdin
instead of requiring $EDITOR. This enables scripted/programmatic
calendar item creation:
cat event.ics | calendula items create <CALENDAR-ID>
When running interactively, behavior is unchanged ($EDITOR opens
with a template). The error message for missing $EDITOR is also
improved to suggest the stdin alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
items createandevents createunconditionally callenv::var("EDITOR"), which fails with "environment variable not found" when$EDITORis not set. This makes it impossible to create items programmatically by piping iCalendar content via stdin:Fix
Check
io::stdin().is_terminal()before deciding the input method:$EDITORwith a template (existing behavior), with an improved error message if$EDITORis not setBoth
src/item/command/create.rsandsrc/event/command/create.rsare fixed (they had identical code).Testing
Tested against iCloud CalDAV — created, verified, and deleted an event via stdin pipe successfully.