fix(storybook): correct staticDirs path for storybook images #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The staticDirs configuration was mapping 'public/img' to 'bundles/pimcorestudioui/img/storybook', but the images are located in 'public/img/storybook/', causing 404 errors for SVG documentation images.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
staticDirsconfiguration in.storybook/main.tswas incorrectly mappingpublic/imgtobundles/pimcorestudioui/img/storybook.Since the storybook images are located in
public/img/storybook/, this caused all SVG documentation images to return 404 errors when running Storybook locally.Changes
staticDirspath frompublic/imgtopublic/img/storybookHow to test
npm installin theassets/directorynpm run storybook