[Document Editor] Add missing preview features #2821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures # Conflicts: # assets/js/src/core/modules/icon-library/index.ts
…-preview-features' into 2172-document-editor-add-missing-preview-features
sholzer
reviewed
Jan 29, 2026
|
sholzer
approved these changes
Jan 29, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds missing preview features to the document editor, specifically implementing device preview modes (desktop, tablet, phone) and a time slider for scheduled content preview.
Changes:
- Added device preview modes with responsive iframe sizing
- Implemented time slider functionality for previewing scheduled content at specific timestamps
- Added new icons (monitor, tablet, phone, phone-horizontal) to support device preview UI
- Enhanced date picker component to optionally show suffix icon
Reviewed changes
Copilot reviewed 18 out of 1452 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| public/build/0fdcc1fe-4c01-481b-be83-593fd9b52885/static/js/async/3156.6d2bbc6b.js | Compiled bundle with new notifyTimeSliderVisible API method |
| assets/js/src/core/modules/icon-library/index.ts | Registered new device preview icons |
| assets/js/src/core/modules/element/dynamic-types/definitions/document/editable/types/dynamic-type-document-editable-scheduledblock.tsx | Added onDocumentReady to notify parent about scheduledblock presence |
| assets/js/src/core/modules/document/hooks/use-document-url-processor.ts | Extended preview URL processor with device type and timestamp parameters |
| assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx | Implemented device preview toolbar and time slider UI |
| assets/js/src/core/modules/document/document-editor-slice.ts | Added Redux state for tracking time slider visibility |
| assets/js/src/core/components/date-picker/date-picker.tsx | Added showSuffixIcon prop to control suffix icon display |
| assets/js/src/core/components/date-picker/date-picker.styles.tsx | Added CSS for conditional suffix icon display |
| assets/js/src/core/app/public-api/document/document-api.ts | Added notifyTimeSliderVisible API method |
| public/build/* | Build artifacts and manifest files |
markus-moser
changed the title
markus-moser
requested changes
Jan 29, 2026
Contributor
markus-moser
left a comment
markus-moser
left a comment
There was a problem hiding this comment.
Hey,
Please check my comments, just a few details :)
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
assets/js/src/core/modules/document/editor/shared-tab-manager/tabs/preview/document-preview.tsx
Show resolved
Hide resolved
markus-moser
approved these changes
Jan 29, 2026
Contributor
markus-moser
left a comment
markus-moser
left a comment
There was a problem hiding this comment.
@MSchinwaldEl Ok fine, sorry the studio.en.yaml was for some reason filtered as vendor file by github when I checked the PR
markus-moser
deleted the
2172-document-editor-add-missing-preview-features
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #2172