2558 brand config images #2851
Merged
2558 brand config images #2851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/studio-ui-bundle into 2558-branding-config-implementation
…ore/studio-ui-bundle into 2558-branding-config-implementation
…rand-config-images
…ui-bundle into 2558-brand-config-images
Corepex
approved these changes
Jan 28, 2026
Contributor
|
LGTM until now - we can have another look if needed :) |
Co-authored-by: Christian F. <christian.feldkirchner@pimcore.com>
Co-authored-by: Christian F. <christian.feldkirchner@pimcore.com>
Co-authored-by: Christian F. <christian.feldkirchner@pimcore.com>
…ui-bundle into 2558-brand-config-images
|
Corepex
approved these changes
Jan 29, 2026
| export const useAdminThumbnails = (): AdminThumbnails => { | ||
| const thumbnailData = useSelector(getThumbnails) | ||
|
|
||
| const isLoadingOrFetching = isUndefined(thumbnailData) || Object.keys(thumbnailData).length === 0 |
Contributor
There was a problem hiding this comment.
Please double-check whether this state is really needed.
Corepex
reviewed
Jan 29, 2026
Contributor
Corepex
left a comment
Corepex
left a comment
There was a problem hiding this comment.
IMHO i would check if we can write the data on update directly into the store. That would save us a request and remove the extraReducer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #2558
Additional info
Screencast.from.2026-01-28.13-06-43.webm