Add timezone when assigning start/end time#1460
Merged
WhyNotHugo merged 2 commits intopimutils:masterfrom Mar 24, 2026
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
It seems to work OK. Going to test on a few others. If anything breaks, I'll let you know. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
If an allday event is created and subsequently edited via khal no timezone data is added to the start and end time and thus the ics-file is not correct. ikhal does this correctly. The problem seems to be that `edit_event` doesn't add timezone data to `start` and `end` prior to calling `update_start_end`. This commit seems to solve this issue. --- fixes pimutils#1459
Commit 4499e6f034d1dc31c03c4e69b292ada2d22e75c3 contains @rtega's fix suggested in pimutils#1459 (comment) in verbatim, attributing them as the author. I think this commit simplifies their proposed changes without affecting the behaviour. Feel free to stash this into the above commit without acknowledging me as an author if you see fit so.
Member
|
Thanks! |
Member
|
Forgot about it: can you add a changelog entry (for v0.14.1) for this too? |
This comment was marked as outdated.
This comment was marked as outdated.
mschilli87
added a commit
to mschilli87/khal
that referenced
this pull request
Mar 24, 2026
Contributor
Author
|
done: #1465 |
WhyNotHugo
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See/fixes #1459.