fix: preserve UDT object identity and lifecycle#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy()detaches the outer objectRoot cause
UDT values were emitted as inline C++ structs, so ordinary assignment accidentally copied object state instead of preserving Pine reference identity. Several adjacent mechanisms then masked one another: typed user methods could collide with built-ins, forward declaration order could hide the authored return type, and collection rollback did not share one mutation order.
Scope boundary
This PR handles UDT identity, typed method dispatch, lifecycle rollback, NA/deletion behavior, and the required map/matrix integration. Direct array fields inside UDTs remain rejected and require a separate design and gate. No strategy data, TradingView tapes, graders, thresholds, or tier files change here.
Validation
git diff --check: cleanDepends on the already-merged engine matrix identity milestone (#129).