feat: custom-notes feature in webui #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of the saved notes and deleted notes.
…several functionalities, not all the functionalities are well tested
| }, []); | ||
|
|
||
| const loadNotes = () => { | ||
| customNotesAPI.pageHandler.getAllNotes().then((response: { notes: Note[] }) => { |
Collaborator
There was a problem hiding this comment.
is it possible to use async await here?
| setNotesList([...notesList, note]); | ||
| setNote(''); | ||
| // Add note to the backend via mojom handler | ||
| customNotesAPI.pageHandler.addNote(note).then(() => { |
Collaborator
There was a problem hiding this comment.
same here. using .then might introduce complications during development
…ting communicated to the frontend.
…y working for api calls.
Author
|
MasterK0927
changed the title
Author
|
Migrated to #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to jot down and save personal notes directly within the browser. The feature includes two main implementations: an in-toolbar button and a dedicated WebUI page.
1. Notes Button in the Toolbar:
Button in the browser toolbar renders a popup when clicked.
Popup allows users to enter and save custom notes or text.
Notes are stored persistently across sessions using the browser's local storage.
2. Dedicated WebUI Page:
Custom Notes feature has been extended to a dedicated WebUI page.
Inkludes option for Summarising and Rephrasing the Notes.
API Calls are tested in two ways :
Uses native JavaScript APIs to perform API calls directly. Certain checks restricting WebUI API calls are disabled to enable this.
Backend communicates with WebUI page via Mojo IPC mechanism, delegating calls to the JavaScript frontend. API calls are routed through the browser’s C++ backend using GURL.
Additonal Comments