Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #20485

First-time contributors' checklist

What is changed, added or deleted? (Required)

增加了日志备份和恢复的兼容性章节。
Added a paragraph that describes the compatibility between log backup and snapshot restore.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

YuJuncen and others added 5 commits December 11, 2025 09:44
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ti-chi-bot ti-chi-bot added lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Dec 11, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TiDB Backup & Restore (BR) documentation by adding crucial information regarding the compatibility between continuous log backup tasks and snapshot restore operations. It clarifies the specific conditions under which these two processes can coexist seamlessly from TiDB v9.0.0 onwards, and provides a structured guide for users to manage scenarios where direct compatibility is not met, ensuring data integrity and operational clarity during recovery procedures.

Highlights

  • New Documentation Section: A new section titled 'Compatibility between ongoing log backup and snapshot restore' has been added to the br-pitr-manual.md file.
  • Compatibility Conditions: The documentation now specifies conditions under which a snapshot restore can be performed while a log backup task is running, starting from TiDB v9.0.0.
  • Incompatible Scenarios Guidance: Clear steps are provided for users to follow if the compatibility conditions are not met or if a point-in-time recovery is required during an ongoing log backup.
  • BR Version Requirement: A note has been added emphasizing the requirement to use BR v9.0.0 or later when restoring a log backup that includes records of snapshot restore data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation regarding the compatibility between log backup and snapshot restore. My review focuses on improving the clarity, grammar, and formatting of the new content to align with the documentation style guide. I have provided several suggestions to make the text more readable and easier for users to understand.

@lilin90 lilin90 assigned lilin90 and unassigned YuJuncen Dec 11, 2025
@qiancai qiancai changed the title br: add compatibility between log backup and PITR (#20485) v8.5.5: br: add compatibility between log backup and PITR (#20485) Dec 12, 2025
@lilin90 lilin90 changed the title v8.5.5: br: add compatibility between log backup and PITR (#20485) v8.5.5 br: add compatibility between log backup and PITR (#20485) Dec 24, 2025
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lilin90. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants