log: support discard action on write timeout#48
Open
bb7133 wants to merge 1 commit into
Open
Conversation
4 tasks
tiancaiamao
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Config.Timeoutcurrently always panics when a log write/sync waits too long for the writer lock. TiDB needs a configurable behavior so operators can choose to discard subsequent logs instead of panicking when log I/O is stuck.What changed and how does it work?
Config.TimeoutActionwith valid actionspanicanddiscard. Empty action keeps the existing panic behavior.LockWithTimeoutas the panic-compatible wrapper.LockWithTimeoutActionfor callers that want discard behavior.Writereturnslen(bs), niland timed-outSyncreturnsnil. After the first timeout, subsequent calls discard immediately while the writer lock is still unavailable, instead of waiting the full timeout repeatedly.Check List
Tests