Skip to content

fix build with node 14 && fix firefox#489

Merged
breezewish merged 7 commits into
pingcap:masterfrom
TennyZhuang:fix-node-14-and-firefox
May 18, 2020
Merged

fix build with node 14 && fix firefox#489
breezewish merged 7 commits into
pingcap:masterfrom
TennyZhuang:fix-node-14-and-firefox

Conversation

@TennyZhuang

@TennyZhuang TennyZhuang commented May 13, 2020

Copy link
Copy Markdown
Contributor

UCP #485
UCP #487

upgrade react-scripts to fix build with node 14
fork sql-formatter-plus to fix running with firefox

@breezewish breezewish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please switch back to use yarnpkg source.

@TennyZhuang
TennyZhuang requested a review from breezewish May 14, 2020 11:30
@breezewish

Copy link
Copy Markdown
Member

Further action item: kufii/sql-formatter-plus#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UCP: Dashboard cannot run in Node 13+ Dashboard does not support Firefox

2 participants