Open
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
requested review from
Benjamin2037,
lance6716,
tiancaiamao and
tisonkun
tisonkun
reviewed
Jan 18, 2023
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Also you may fix the markup backquote in the following sections.
| ### Running all tests | ||
|
|
||
| You can always run all tests by executing the `gotest` target in Makefile: | ||
| We have two ways to run all tests. The first one is to use `go test` directly: |
Contributor
There was a problem hiding this comment.
make ut is not "use go test directly"
| ``` | ||
|
|
||
| This is almost equivalent to `go test ./...` but it enables and disables fail points before and after running tests. | ||
| The second one is to use bazel to run tests. The bazel will cache the test results and it is faster than the first one. But it need more storage space to save the cache. it is recommended to use the first one in the CI. |
Contributor
There was a problem hiding this comment.
Suggested change
| The second one is to use bazel to run tests. The bazel will cache the test results and it is faster than the first one. But it need more storage space to save the cache. it is recommended to use the first one in the CI. | |
| The second one is to use bazel to run tests. Bazel will cache the test results and it is faster than the first one. But it needs more storage space to save the cache. |
Also, I don't understand what " it is recommended to use the first one in the CI." means: you're talking about the second approach but now said the first approach is recommended in CI? Or what do you want to mean?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What issue does this PR solve?
What is changed: