sync-diff-inspector: Not to include fix sqls for disk write when exportFixSQL is false #871
sync-diff-inspector: Not to include fix sqls for disk write when exportFixSQL is false #871mengxian-li wants to merge 2 commits intopingcap:masterfrom
Conversation
sync-diff-inspector: Not to include fix sqls for disk write when exportFixSQL is false
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @mengxian-li. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @mengxian-li! |
What problem does this PR solve?
Issue Number: close #870
What is changed and how it works?
Guard this line where fix sqls are added for disk write with
export-fix-sql.So there won't be fix sql files created on the disk with chunk metadata.
Check List
Tests