Skip to content

Load Claude user and project settings sources#1299

Open
Jeccoman wants to merge 1 commit intopingdotgg:mainfrom
Jeccoman:fix/claude-setting-sources
Open

Load Claude user and project settings sources#1299
Jeccoman wants to merge 1 commit intopingdotgg:mainfrom
Jeccoman:fix/claude-setting-sources

Conversation

@Jeccoman
Copy link

@Jeccoman Jeccoman commented Mar 22, 2026

What Changed

This updates the Claude adapter to pass settingSources: ["user", "project"] when creating Claude SDK queries, and adds a regression test covering the query options.

Why

Claude settings from user and project config were not being loaded for these queries, so repo-level and user-level Claude configuration could be ignored. This keeps the adapter aligned with expected Claude config resolution and fixes the missing settings behavior with a minimal change.

UI Changes

Checklist

  • [v ] This PR is small and focused
  • [v ] I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Load user and project settings sources in Claude adapter queries

Adds settingSources: ["user", "project"] to the options passed to createQuery in ClaudeAdapter.ts, ensuring Claude resolves settings from both user and project scopes. A corresponding test verifies the property is present on the query options.

Macroscope summarized 8b1a0a2.

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 91084c53-b3da-49f4-bb7c-2c61f848b8d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant