Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/uploadthing/src/convex.tspackages/uploadthing/src/convex-helpers.tsDesign decisions
Request/Response, and adapt at the Convex boundary usinginternalActionGeneric. Mirrors existing framework adapters and avoids Convex-specific leakage.{ url, method, headers, body? }and reconstruct aRequestinside the action.Developer experience
Usage sketch:
Required env on convex:
UPLOADTHING_TOKENThanks for taking a look! I’m happy to iterate on naming, paths, or API surface to fit project.
Summary by CodeRabbit
New Features
Documentation
Examples
Chores