Conversation
DarKhaos
commented
Jun 2, 2026
DarKhaos
commented
- Added RewriteRuleProcessor to handle rewriting logic based on defined rules.
- Introduced findActiveRewriteRules method in RewriteRuleService to filter rules by locale and repository.
- Updated ThirdPartyTMSSmartlingWithJson to integrate RewriteRuleProcessor for content rewriting.
- Modified SmartlingPullLocaleFileJob and SmartlingPullLocaleFileJobInput to accommodate repository ID.
- Enhanced tests for RewriteRuleProcessor and related services to ensure correct functionality and coverage.
- Added RewriteRuleProcessor to handle rewriting logic based on defined rules. - Introduced findActiveRewriteRules method in RewriteRuleService to filter rules by locale and repository. - Updated ThirdPartyTMSSmartlingWithJson to integrate RewriteRuleProcessor for content rewriting. - Modified SmartlingPullLocaleFileJob and SmartlingPullLocaleFileJobInput to accommodate repository ID. - Enhanced tests for RewriteRuleProcessor and related services to ensure correct functionality and coverage.
maallen
reviewed
Jun 3, 2026
maallen
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.