Skip to content

Attempt to fix MetadataClient reflections race condition (#119) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffxiang merged 1 commit into from
Jan 12, 2026
Merged

Attempt to fix MetadataClient reflections race condition (#119) #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions psc/src/main/java/com/pinterest/psc/metadata/creation/PscMetadataClientCreatorManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.pinterest.psc.metadata.creation;

import com.pinterest.psc.common.PscUtils;
import com.pinterest.psc.logging.PscLogger;
import org.reflections.Reflections;

Expand All @@ -26,36 +27,38 @@ public class PscMetadataClientCreatorManager {
findAndRegisterMetadataClientCreators(PscMetadataClientCreatorManager.class.getPackage().getName());

private static Map<String, List<PscBackendMetadataClientCreator>> findAndRegisterMetadataClientCreators(String packageName) {
Map<String, List<PscBackendMetadataClientCreator>> backendCreatorRegistry = new HashMap<>();
Reflections reflections = new Reflections(packageName.trim());
Set<Class<?>> annotatedClasses = reflections.getTypesAnnotatedWith(PscMetadataClientCreatorPlugin.class);
for (Class<?> annotatedClass : annotatedClasses) {
PscMetadataClientCreatorPlugin plugin = annotatedClass.getAnnotation(PscMetadataClientCreatorPlugin.class);
if (plugin == null) {
logger.error("Plugin info null: " + annotatedClass.getName());
continue;
}
String backend = plugin.backend();
if (backend.isEmpty()) {
logger.warn("Ignoring due to empty backend for plugin: " + annotatedClass.getName());
continue;
}
try {
PscBackendMetadataClientCreator creator =
(PscBackendMetadataClientCreator) annotatedClass.getDeclaredConstructor().newInstance();
List<PscBackendMetadataClientCreator> creators =
backendCreatorRegistry.computeIfAbsent(backend, ignored -> new ArrayList<>());
logger.info("Adding PscBackendMetadataClientCreator: {} with priority: {}", creator.getClass().getName(), getPriority(creator));
creators.add(creator);
creators.sort(Comparator.comparingInt(PscMetadataClientCreatorManager::getPriority));
Collections.reverse(creators); // Sort in descending order of priority
} catch (ReflectiveOperationException e) {
throw new RuntimeException("Failed to register PscBackendMetadataClientCreator", e);
synchronized (PscUtils.lock) {
Map<String, List<PscBackendMetadataClientCreator>> backendCreatorRegistry = new HashMap<>();
Reflections reflections = new Reflections(packageName.trim());
Set<Class<?>> annotatedClasses = reflections.getTypesAnnotatedWith(PscMetadataClientCreatorPlugin.class);
for (Class<?> annotatedClass : annotatedClasses) {
PscMetadataClientCreatorPlugin plugin = annotatedClass.getAnnotation(PscMetadataClientCreatorPlugin.class);
if (plugin == null) {
logger.error("Plugin info null: " + annotatedClass.getName());
continue;
}
String backend = plugin.backend();
if (backend.isEmpty()) {
logger.warn("Ignoring due to empty backend for plugin: " + annotatedClass.getName());
continue;
}
try {
PscBackendMetadataClientCreator creator =
(PscBackendMetadataClientCreator) annotatedClass.getDeclaredConstructor().newInstance();
List<PscBackendMetadataClientCreator> creators =
backendCreatorRegistry.computeIfAbsent(backend, ignored -> new ArrayList<>());
logger.info("Adding PscBackendMetadataClientCreator: {} with priority: {}", creator.getClass().getName(), getPriority(creator));
creators.add(creator);
creators.sort(Comparator.comparingInt(PscMetadataClientCreatorManager::getPriority));
Collections.reverse(creators); // Sort in descending order of priority
} catch (ReflectiveOperationException e) {
throw new RuntimeException("Failed to register PscBackendMetadataClientCreator", e);
}
}
backendCreatorRegistry.replaceAll((backend, creators) ->
Collections.unmodifiableList(new ArrayList<>(creators)));
return Collections.unmodifiableMap(backendCreatorRegistry);
}
backendCreatorRegistry.replaceAll((backend, creators) ->
Collections.unmodifiableList(new ArrayList<>(creators)));
return Collections.unmodifiableMap(backendCreatorRegistry);
}

private static int getPriority(PscBackendMetadataClientCreator creator) {
Expand Down