Remove machine-specific paths from examples - #4
Merged
Conversation
- DEFAULT_SPARSE_MAT was hardcoded to an absolute path on the author's machine (/celerina/gfp/mfs/...). It now reads the SHEARWAVE_SPARSE_MAT environment variable and defaults to the relative file name "Sparse_TransConnector.mat" (still overridable via --connector-path). - DOCS_FIGURES_DIR pointed at ../paper/figures, which no longer exists in the repo (manuscripts are distributed separately). It is now opt-in via the SHEARWAVE_DOCS_FIGURES_DIR environment variable and defaults to None, so the examples no longer write into a manuscript directory. save_fig already no-ops when docs_dir is None. No remaining machine-specific absolute paths in tracked files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R3eMurRYQsmx58nU2yFwAF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last computer-specific paths from tracked files.
DEFAULT_SPARSE_MAT(was/celerina/gfp/mfs/.../Sparse_TransConnector.mat) →SHEARWAVE_SPARSE_MATenv var, relative default, still overridable via--connector-path.DOCS_FIGURES_DIR(pointed at the removedpaper/figures) → opt-inSHEARWAVE_DOCS_FIGURES_DIRenv var, defaults toNoneso examples no longer write into a manuscript dir.Verified:
git grepfinds no/celerina,/home,/Users,/mntabsolute paths in tracked files; both examples parse.🤖 Generated with Claude Code
https://claude.ai/code/session_01R3eMurRYQsmx58nU2yFwAF