Update CI configs to v0.12.1#367
Merged
Merged
Conversation
Update lint scripts and CI configs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 82.63% 82.63%
=======================================
Files 19 19
Lines 1457 1457
=======================================
Hits 1204 1204
Misses 140 140
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- gosec G115: Add nolint for safe bit-shift integer conversions in key derivation and test data - modernize: Use range over int, remove forvar copies - gci: Fix nolint comment alignment
JoTurk
approved these changes
Mar 27, 2026
Comment on lines
+63
to
+71
| counter[5] ^= byte(ssrc >> 16) //nolint:gosec | ||
| counter[6] ^= byte(ssrc >> 8) //nolint:gosec | ||
| counter[7] ^= byte(ssrc) //nolint:gosec | ||
| counter[8] ^= byte(rolloverCounter >> 24) | ||
| counter[9] ^= byte(rolloverCounter >> 16) | ||
| counter[10] ^= byte(rolloverCounter >> 8) | ||
| counter[11] ^= byte(rolloverCounter) | ||
| counter[9] ^= byte(rolloverCounter >> 16) //nolint:gosec | ||
| counter[10] ^= byte(rolloverCounter >> 8) //nolint:gosec | ||
| counter[11] ^= byte(rolloverCounter) //nolint:gosec | ||
| counter[12] ^= byte(sequenceNumber >> 8) | ||
| counter[13] ^= byte(sequenceNumber) | ||
| counter[13] ^= byte(sequenceNumber) //nolint:gosec |
Member
There was a problem hiding this comment.
we can maybe add a comment to explain that it's a false positive or what linter we're suppressing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update lint scripts and CI configs.