Store *[]byte in bufferPool to avoid allocation on Put#368
Merged
JoTurk merged 2 commits intoMar 27, 2026
Conversation
sync.Pool boxes values into any (interface{}). Storing []byte directly
causes the 24-byte slice header to be heap-allocated on every Put().
Storing *[]byte avoids this since the pointer is already on the heap.
This is the same pattern used in Go stdlib (fmt.pp, encoding/json).
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 82.63% 82.42% -0.22%
==========================================
Files 19 19
Lines 1457 1462 +5
==========================================
+ Hits 1204 1205 +1
- Misses 140 142 +2
- Partials 113 115 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sync.Pool boxes values into any (interface{}). Storing []byte directly causes the 24-byte slice header to be heap-allocated on every Put(). Storing *[]byte avoids this since the pointer is already on the heap.
This is the same pattern used in Go stdlib (fmt.pp, encoding/json).