Nemotron 3.0 and 3.5 ASR - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds NVIDIA Nemotron ASR results to the published benchmark table and updates the Pareto plotting script to optionally treat the committed README results table as the metrics source (bypassing local DB access), so generated charts can match published numbers even when raw benchmark runs aren’t available locally.
Changes:
- Add NVIDIA Nemotron 3.0/3.5 rows to the README “Results Summary” table.
- Add
--from-readmemode and a README-table parser (get_data_from_readme) topareto-frontier-plot.py. - Add optional label-capitalization control for the Pareto-frontier “bottom panel” service list.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/pareto-frontier-plot.py | Adds README-as-source option and label handling for plotting. |
| README.md | Publishes NVIDIA Nemotron 3.0/3.5 ASR benchmark metrics in the results table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
221
to
+223
| for name, ttfb, wer in pareto_optimal: | ||
| service_strs.append(f"{name.capitalize()}: {ttfb:.0f}ms, WER {wer:.2f}%") | ||
| label = name.capitalize() if capitalize_labels else name | ||
| service_strs.append(f"{label}: {ttfb:.0f}ms, WER {wer:.2f}%") |
Comment on lines
+550
to
+556
| # Generate the README results table from the same (plot-config) services, | ||
| # using registry labels + DB metrics. Do this before display-name remapping | ||
| # so we still have service keys to look up vendor/model_label. | ||
| table_md = generate_markdown_table(data) | ||
| readme_path = Path(__file__).parent.parent / "README.md" | ||
| if update_readme_table(table_md, readme_path): | ||
| print(f"\nUpdated results table in: {readme_path}\n") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added, as per: https://x.com/kwindla/status/2062544580105359686