GRAL-5509 Fix API v2 host path configuration #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/duplicate endpoint. Add deal_id query parameter to the GET /v2/persons endpoint. Add GET /v1/leadFields endpoint
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an API v2 host path configuration issue where the base path was incorrectly set to /v2 instead of /api/v2. The same fix is applied to API v1, changing from /v1 to /api/v1 (though both paths remain supported for v1). Additionally, the PR includes several API enhancements: a new product duplication endpoint, a deal_id query parameter for filtering persons, and a new endpoint for fetching lead fields.
Key Changes:
- Fixed API v2 and v1 host path configuration by adding
/apiprefix - Added duplicate product functionality to v2 API
- Enhanced person filtering with deal_id parameter in v2 API
- Added lead fields retrieval endpoint to v1 API
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/versions/v2/Configuration.php | Updated host path from /v2 to /api/v2 in OAuth and default configuration |
| lib/versions/v1/Configuration.php | Updated host path from /v1 to /api/v1 in OAuth and default configuration |
| lib/versions/v2/Api/ProductsApi.php | Added new duplicateProduct operation with sync/async implementations |
| lib/versions/v2/Api/PersonsApi.php | Added deal_id parameter to getPersons method signatures and request handling |
| lib/versions/v1/Api/LeadFieldsApi.php | New API class for lead fields operations |
| docs/versions/v2/README.md | Added documentation reference for duplicate product endpoint |
| docs/versions/v2/Api/ProductsApi.md | Added complete documentation for duplicate product endpoint |
| docs/versions/v2/Api/PersonsApi.md | Updated documentation to include deal_id parameter |
| docs/versions/v1/README.md | Added documentation reference for lead fields endpoint |
| docs/versions/v1/Api/LeadFieldsApi.md | New documentation file for lead fields API |
| CHANGELOG.md | Added changelog entry documenting all changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nikita-masalov
approved these changes
Nov 25, 2025
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for the reported issue #252 and proposed fix https://github.com/pipedrive/client-php/pull/260/files
This PR also combines some previous
minorversion updates:#256
#258
#259
Type of PR
🚀 Enhancement
🚧 Maintenance
Manual testing