Merge main (automation extra_input fix) into the remote-safe read stack#448
Closed
mocha06 wants to merge 5 commits into
Closed
Merge main (automation extra_input fix) into the remote-safe read stack#448mocha06 wants to merge 5 commits into
mocha06 wants to merge 5 commits into
Conversation
… --extra help CreateAutomationInput/UpdateAutomationInput mix naming styles: most fields are snake_case (action_params, event_id) but a few are camelCase (schedulerCron, responseSchema, searchFor). The CLI --extra help claimed camelCase, so the documented form was rejected by the API. PipefyClient.create_automation/update_automation now rewrite top-level extra_input keys to the API field names via a pure alias map (nested payloads pass through verbatim), so both spellings work from the CLI and MCP surfaces. Help text and docstrings now name the API fields instead of claiming camelCase. Closes #275
…rtising aliases The normalizer accepting both spellings is a silent safety net; documenting it made the LLM stop and choose. Lead the MCP tool docstrings with 'mirror get_automation output' and present top-level extra_input keys as snake_case, dropping the 'camelCase aliases accepted' language. Keep a short 'camelCase also accepted' note in the human-facing CLI help. No behavior change; the normalizer still accepts both spellings.
…nput guidance The reference doc opened with 'extra_input (camelCase API keys)', contradicting the tool docstrings and the doc's own snake_case examples. Same class of confusion as #275: agents reading the doc instead of the tool schema would send the wrong shape. Also drop a meaningless 'or camelCase active' aside (active has no case variant). Addresses review feedback F1 on #352.
fix(sdk): accept both key spellings in automation extra_input and fix --extra help
…in-into-remote-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the changes that shipped directly to
main(bypassingdev) into the remote-safe read stack, on top of #447 (rc-dev/feat/remote-safe-core-reads).Motivation
An automation
extra_inputcase-normalization fix (PR #352) landed onmainwithout going throughdev, sodevand everything stacked on it (the remote-safe read PRs #443–#447) were missing it. This mergesmaininto the stack tip so the stack is current.Outcome
mainwasdev+ PR #352 only, so the merge is clean — no conflicts, no logical issues:packages/mcp/src/pipefy_mcp/tools/automation_tools.pycarries both the incomingextra_inputhandling and this stack'smeta=REMOTEmarkers on the automation read tools (non-overlapping regions).automation_input.pymodule andtest_automation_input.pyare present and pass; the CLI help golden matches the merged automation help.ruff check/ruff format --check, thetest_remote_profile.pydrift-guard, the CLI help golden (no update needed), and the full suite.Note
Base is #447's branch (stacked), so CI fires once the base retargets to
devon merge. Merge this into the stack before (or alongside) merging #443→#447 down todev, so the automation fix rides along.