document player properties, ed25519 auth, and utf-8 chat extensions#54
document player properties, ed25519 auth, and utf-8 chat extensions#54Fran6nd wants to merge 3 commits into
Conversation
ac25576 to
5993fe0
Compare
|
Up :) @utf-4096 |
|
Don’t have review permissions, but looks fine. |
Ach sorry I thought you had it. |
add per-field and per-offset tables for sub-packet 0 so implementers have a clear wire-level description rather than just the 12-byte total.
|
Oops I'll have to fix the repo permissions |
|
BTW, in my last commit (after PR approval) I did split the documentation of player properties into two tables to avoid having an ultra wide table. Let me know if you prefer me to merge them. |
0--255, 0 HP in betterspades does not kill the player (that's what the kill packet is for. . .) -- does in openspades which doesn't support this packet though
May or may not actually be a (signed) int32_t. |
|
Updated according to your comment @DavidCo113 I did check how score is handled but only on 3 clients though. BetterSpades, KyroSpades and ZeroSpades. |
Did you test it or just go off the source code? TigerSpades certainly treats it as signed, despite the struct being unsigned. |
Bring extensions.md in line with libspades' extension docs — adds
Player Properties (id 0), Ed25519 Authentication (id 1), and a note
about UTF-8 Chat. Also fills in the empty has-packets table in
index.md so it actually lists something.
These are not really proposals as these have already been widely adopted.
Sources: