Compact the Mini App word library - #149
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 392efe6ee3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div id="empty-words" class="state-card dashboard-state empty" data-ui-state="empty" role="status" hidden><p data-i18n="empty_words"></p><button class="dashboard-action" type="button" data-action="continue" data-i18n="start_lesson"></button></div> | ||
| <section class="word-library" data-i18n-aria-label="word_library_title"> | ||
| <div class="word-library-tabs" role="tablist" data-i18n-aria-label="word_library_title"> | ||
| <button id="word-library-custom-tab" class="word-library-tab" type="button" role="tab" aria-selected="true" aria-controls="word-library-custom-panel" tabindex="0" data-word-library-tab="custom"> |
There was a problem hiding this comment.
When either new library tab is clicked, it also matches the existing global document.querySelectorAll('[role="tab"]') in miniapp.js and receives the primary activateTab handler. Because these buttons have no data-tab, that handler hides every [data-panel], including the containing Words panel; the later library-specific handler cannot reveal it. Normal bottom-nav activation also clears the nested tabs' selected state. Restrict the primary selector/listeners to the five data-tab buttons so the two tab groups operate independently.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
python -m unittest discover -s tests -p "test_*.py"— 1195 passed, 3 skippedpython -m compileall -q mydictionarygit diff --check