Guide learners from cards to active recall - #151
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6980e3a4de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elif user_data.get("block_mode") == "quiz": | ||
| primary = InlineKeyboardButton( | ||
| translate("block_reinforce_written", locale), | ||
| callback_data=f"bmode:{session_id}:type", |
There was a problem hiding this comment.
When a learner follows the new primary actions after perfect cards and quiz attempts, both callbacks start fresh, normally scored attempts over block_all_indices; each correct answer therefore runs through block_advance/bot_learning.rate and increments the same word's correct_count. A brand-new word can consequently go from 0 to 3 and receive a seven-day interval during one uninterrupted lesson, immediately satisfying the canonical “durable word” metric and postponing its first spaced review. These same-session reinforcement attempts need separate/non-SRS scoring, or otherwise must not advance the interval as independent reviews.
AGENTS.md reference: AGENTS.md:L10-L12
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
Outcome
Evidence
Rollback
Revert commit
6980e3a.