Make Mirror a continuous language teacher - #152
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a6a02f458
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mentioned = ( | ||
| compact_term in compact_haystack | ||
| if uses_compact_matching | ||
| else f" {term} " in padded_haystack |
There was a problem hiding this comment.
Match CJK terms without treating substrings as words
For Chinese or Japanese packs, this substring check records shorter catalog entries that merely occur inside a longer word. For example, an exchange containing 女人 also matches and persists 人, while 对不起 matches 对 and 不; those extra entries then appear in My Words and as recently practised terms despite never being exposed independently. Use CJK-aware boundaries or a longest-match segmentation strategy rather than testing every compact term with in.
Useful? React with 👍 / 👎.
Summary
Verification