Simplify Mini App card-mode selection - #153
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4b286762d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| Object.entries(additional).forEach(([locale, values]) => Object.assign(copies[locale], Object.fromEntries(["resume", "pause", "audio_error", "mix", "start"].map((key, index) => [key, values[index]])))); | ||
| const modeUx = { | ||
| en: {mode_prompt: "Choose a mode", mix_hint: "Recommended: due reviews first, then new words.", forgotten_hint: "Only words that are due for review.", new_hint: "Only words you have not studied yet.", mix_start: "Start smart mix", forgotten_start: "Start review", new_start: "Learn new words"}, |
There was a problem hiding this comment.
For learners who recently answered a word incorrectly, this explanation is false: _pools() in mydictionary/swipe.py adds words with wrong_count > 0 and correct_count < 3 to the forgotten pool even when next_review is still in the future. Selecting Review can therefore show non-due mistake words despite promising “Only words that are due for review”; update this hint and its localized equivalents to describe the actual pool.
Useful? React with 👍 / 👎.
1 participant
Outcome
Verification
python -m unittest discover -s tests: 1216 passed, 3 skippednode --test tests/browser/learning-flow-v2.cjs: 11 passedgit diff --checkCloses no issue; contributes to #6.