Turn public dictionary into a learning profile - #154
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2262a75966
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $("result-status").textContent=matches.length>50?t("truncated",{shown:50,count:matches.length}):t("results",{count:matches.length}); | ||
| const shown=matches.slice(0,visibleLimit); $("dictionary-results").replaceChildren(...shown.map(row)); | ||
| $("result-status").textContent=matches.length>shown.length?t("truncated",{shown:shown.length,count:matches.length}):t("results",{count:matches.length}); | ||
| $("show-more-results").hidden=shown.length>=matches.length; |
There was a problem hiding this comment.
With the default 100-word pack, this button is visible when the user starts a five-card review because the practice-start handler hides the results but not #show-more-results. The active exercise is therefore followed by an unrelated, clickable “Show more” control; clicking it rerenders background result state and can also reveal the translation panel when a query was present. Hide pagination on practice entry or make its visibility conditional on there being no active session.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
DATABASE_URL=sqlite:////tmp/.../suite.db ALLOW_SQLITE_DEV=true .venv/bin/python -m unittest discover -s tests(1220 passed, 3 skipped)git diff --checkCloses no issue; contributes to #6.