Skip to content

Polish Telegram Stars and RTL language rows - #156

Merged
pirajoke merged 1 commit into
mainfrom
codex/stars-rtl-catalog-500-20260921
Sep 21, 2026
Merged

pirajoke merged 1 commit into
mainfrom
codex/stars-rtl-catalog-500-20260921

Conversation

@pirajoke

Copy link
Copy Markdown
Owner

Summary

  • replace visible XTR codes with a Telegram Stars visual price component while keeping XTR in the payment API
  • keep language rows on one stable grid and isolate Arabic RTL direction to the language name
  • refresh Mini App cache versions and protect both behaviors with contracts

Verification

  • 1222 tests passed, 3 skipped, on a clean temporary SQLite database
  • focused Mini App, Telegram Stars, language, and pack checks passed
  • JavaScript syntax, Python compileall, and git diff checks passed
  • mobile 390px visual review passed

Catalog note

The public catalog currently contains eight 100-word packs and one 101-word Vietnamese pack. Expanding every public language to 500 requires 3,599 reviewed entries; this PR intentionally does not fake counts or duplicate content.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T07:52:14.062396Z 7715166 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 771516668c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

function telegramStarsPrice(amount) {
const price = document.createElement("span");
price.className = "product-card-price";
price.setAttribute("aria-label", `${amount} Telegram Stars`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Expose a localized Stars currency label

For screen-reader users, this aria-label is placed on an implicit generic span, whose role does not reliably support an accessible name; because the star itself is also aria-hidden, the enclosing purchase button may announce only the bare amount and omit its currency. Even where the label is honored, it is hard-coded in English despite the app's eight interface locales. Use a supported semantic element or visually hidden localized text so the amount is consistently announced as Telegram Stars.

Useful? React with 👍 / 👎.

@pirajoke
pirajoke merged commit 37da035 into main Sep 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant