Expand core language packs to 500 words - #159
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d447404ecb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| JA_ROMAJI.update({ | ||
| "...になる": "ninaru", |
There was a problem hiding this comment.
Adding the 400 terms only to JA_ROMAJI leaves LANG_TOPIC_TERMS["ja"] covering the original vocabulary. Because schema-v1 Japanese entries carry no canonical topics, topics_for_word() consequently assigns every appended word to general; learners selecting greetings, food, travel, actions, and the other themed lessons still receive only the old words rather than the advertised expansion.
Useful? React with 👍 / 👎.
| cold descriptions холодный имеющий низкую температуру cold|/koʊld/ froid|/fʁwa/ kalt|/kalt/ بارد|bārid 冷|lěng холодный|kholodnyy frío|/ˈfɾi.o/ | ||
| happy descriptions счастливый испытывающий радость happy|/ˈhæpi/ heureux|/ø.ʁø/ glücklich|/ˈɡlʏklɪç/ سعيد|saʿīd 高兴|gāoxìng счастливый|schastlivyy feliz|/feˈliθ/ | ||
| sad descriptions грустный испытывающий печаль sad|/sæd/ triste|/tʁist/ traurig|/ˈtʁaʊʁɪç/ حزين|ḥazīn 难过|nánguò грустный|grustnyy triste|/ˈtɾiste/ | ||
| advice greetings совет понятие или предмет: совет advice|/ædˈvaɪs/ conseil|/kɔ̃sɛj/ Rat|/ʁaːt/ نَصِيحَة|nasiyhaa 劝告|quàn gào сове́т|sovet consejo|/kõnˈsexo/ |
There was a problem hiding this comment.
When a learner selects the Greetings topic in any generated schema-v2 pack, this starts a 40-row run containing advice, article, blog, information, paragraph, report, and similar communication vocabulary. Combined with the original ten greetings, most of the resulting 50-word lesson is unrelated to the catalog's “Приветствия” label, while a dedicated communication topic already exists.
Useful? React with 👍 / 👎.
| happy descriptions счастливый испытывающий радость happy|/ˈhæpi/ heureux|/ø.ʁø/ glücklich|/ˈɡlʏklɪç/ سعيد|saʿīd 高兴|gāoxìng счастливый|schastlivyy feliz|/feˈliθ/ | ||
| sad descriptions грустный испытывающий печаль sad|/sæd/ triste|/tʁist/ traurig|/ˈtʁaʊʁɪç/ حزين|ḥazīn 难过|nánguò грустный|grustnyy triste|/ˈtɾiste/ | ||
| advice greetings совет понятие или предмет: совет advice|/ædˈvaɪs/ conseil|/kɔ̃sɛj/ Rat|/ʁaːt/ نَصِيحَة|nasiyhaa 劝告|quàn gào сове́т|sovet consejo|/kõnˈsexo/ | ||
| agree greetings соглашаться действие: соглашаться agree|/əˈɡɹi/ être d'accord|/\ɛtʁ\ \de\ \a.kɔʁ\/ zustimmen|/ˈt͡suːˌʃtɪmən/ وَافَقَ|waafaqa 同意|tóng yì соглаша́ться|soglashatsya estar de acuerdo|/esˈt̪aɾ d̪e aˈkweɾð̞o/ |
There was a problem hiding this comment.
For French learners, this transcription is rendered literally as /\ɛtʁ\ \de\ \a.kɔʁ\/ rather than IPA. The same regex-style escaping appears in 17 new French entries (including blog, email, cheap, bedroom, and remember), so pronunciation cards expose backslashes even though the current validation only checks the surrounding slashes.
Useful? React with 👍 / 👎.
| "en": "競技場", | ||
| "ru": "парк", |
There was a problem hiding this comment.
In the Japanese pack, the card for Russian парк now teaches 競技場, which means a stadium or athletic ground rather than a park (公園). This causes cards, quizzes, and written practice to reinforce and grade the wrong translation.
Useful? React with 👍 / 👎.
| "entry_id": "begin", | ||
| "target": "開始", | ||
| "meaning": "начать", |
There was a problem hiding this comment.
The Chinese pack is configured for zh-CN and otherwise uses simplified forms, but this new entry stores traditional 開始 instead of simplified 开始 (with other additions such as 建設 showing the same mixing). Learners therefore receive inconsistent orthography, and local searches using the common simplified spelling cannot match these entries.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification