Fixed etime parsing issue#1
Open
jbot-the-dev wants to merge 1 commit into
Open
Conversation
jbot-the-dev
commented
Jan 11, 2022
jbot-the-dev
commented
- datetime.strptime %M%S does not work for etime.
- The etime format is MMMSS, with M being minutes and S being seconds, and without any zero left-padding.
- %M%S only works for a maximum of 59 minutes and 59 seconds.
- Single digits were being skipped, as were any values greater than 5959.
- Two digits were being parsed as MS, where they should be SS.
- Three digits were being parsed as MMS, unless MM > 59, then it would parse as MSS.
- Parsing is actually faster now, since datetime is not being used.
- datetime.strptime %M%S does not work for etime. - The etime format is MMMSS, with M being minutes and S being seconds, and without any zero left-padding. - %M%S only works for a maximum of 59 minutes and 59 seconds. - Single digits were being skipped, as were any values greater than 5959. - Two digits were being parsed as MS, where they should be SS. - Three digits were being parsed as MMS, unless MM > 59, then it would parse as MSS. - Parsing is actually faster now, since datetime is not being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.