Skip to content

fix(a11y): add aria-label to icon-only buttons in EnvManager#503

Open
RavindiFernando wants to merge 1 commit into
piyushdotcomm:mainfrom
RavindiFernando:fix/env-manager-aria-labels
Open

fix(a11y): add aria-label to icon-only buttons in EnvManager#503
RavindiFernando wants to merge 1 commit into
piyushdotcomm:mainfrom
RavindiFernando:fix/env-manager-aria-labels

Conversation

@RavindiFernando

Copy link
Copy Markdown
Contributor

Summary

  • Added aria-label to the Plus (Add Variable) icon button in the Env Manager header, replacing title which is only surfaced as a visual tooltip
  • Added aria-label={Remove variable ${idx + 1}} to each row's Trash icon button so screen readers can distinguish between them
  • Updated tests/env-manager.test.tsx to forward aria-label through the Button mock and replaced getByTitle queries with getByRole("button", { name: ... }) to align with the new attribute

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Test or CI improvement
  • Starter template change

Related issue

Closes #283

Validation

  • npm run lint
  • npm test
  • npm run build

List any additional manual verification you performed:

  • N/A

Screenshots or recordings

N/A. No visual change; accessibility attribute only.

Checklist

  • I kept this PR focused on one primary change
  • I updated documentation if behavior changed
  • I did not commit secrets, local logs, or scratch files
  • I am requesting review on the correct scope

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions

Copy link
Copy Markdown

👋 Thanks for opening a PR, @RavindiFernando!

Your PR has entered the 🚦 PR Review Pipeline.

Standard PR detected — your PR will follow the standard review pipeline.


What happens next

Stage Reviewer Checks
Stage 1 — Automated Validation 🤖 Bot DCO · Format · AI/Slop · Duplicate
Stage 2 — Human Review 👥 Maintainer Code + Quality Review
Stage 3 — PA / Maintainer Review 🔑 Project Admin Final Merge Decision

A pipeline status comment will appear below and update automatically as your PR progresses.


While you wait

  • Sign all commits (git commit -s)
  • Link your issue (Closes #123)
  • Use a feature branch (not main)
  • Avoid unrelated changes

This comment is posted only once.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@RavindiFernando, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 37 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cbbffba8-56ae-43a3-9f52-ef3bfada5378

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb728f and 335a956.

📒 Files selected for processing (2)
  • modules/playground/components/env-manager.tsx
  • tests/env-manager.test.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: RavindiFernando <ravindifernando3@gmail.com>
@RavindiFernando RavindiFernando force-pushed the fix/env-manager-aria-labels branch from 3dfee16 to 335a956 Compare June 20, 2026 12:08
@Maxd646 Maxd646 self-requested a review June 22, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing aria-label to icon buttons in Env Manager

2 participants