Follow pkgr master in E2E workflows - #5
Merged
Merged
Conversation
Member
Author
|
@codex review |
1 similar comment
Member
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The cross-repository bootstrap pin was needed before the local buildcurl images were published. Keeping that SHA now freezes action E2Es on the rollout commit.
Root cause
Both E2E workflows hardcoded one
PKGR_VERSION. Simply using mutablemasterindependently in each job could also mix revisions during a run.What changed
pkgrmaster.workflow_dispatchoverride acceptingmasteror an exact lowercase SHA.Validation
actionlint .github/workflows/test.yml .github/workflows/scheduled-e2e.ymlgit diff --check origin/v1...HEAD