chore: optimize panic msg#21
Merged
Merged
Conversation
2b0c84b to
15e9728
Compare
|
I think when panic as "invalid basic block name: {}", you can also show the rules like this: "basic block name should start with '%' or '@' and not only the single '%' or '@' symbol". I think this warning message appears when you give wrong name to a value. You can reuse that sentence. |
15e9728 to
902c96b
Compare
Contributor
Author
|
Fair enough. It's updated.
|
MaxXSoft
reviewed
Mar 4, 2026
902c96b to
bfe5911
Compare
bfe5911 to
54bb2b0
Compare
Member
|
LGTM. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what does this PR do?
BasicBlockBuilder::callwhere the length of params and args are not checked.