Skip to content

fix: prevent interview crash from incomplete data extraction #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhekanik merged 6 commits into from
Oct 12, 2025
Merged

fix: prevent interview crash from incomplete data extraction #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d71c944
fix: prevent interview creation with incomplete job data
bhekanik Oct 12, 2025
961269b
feat: add dynamic cache invalidation for incomplete job data
bhekanik Oct 12, 2025
6dfff82
style: apply Biome formatting to migrations and Lambda function
bhekanik Oct 12, 2025
dba2170
fix: add polling to detect extraction completion
bhekanik Oct 12, 2025
45aac3c
docs: clarify staleTime vs refetchInterval behavior in useJob
bhekanik Oct 12, 2025
fecf6ee
docs: apply same comment clarifications to useInterview
bhekanik Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 44 additions & 144 deletions db/migrations/meta/0009_snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,8 @@
"name": "candidate_details_job_id_jobs_id_fk",
"tableFrom": "candidate_details",
"tableTo": "jobs",
"columnsFrom": [
"job_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["job_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -268,9 +264,7 @@
"countries_isoCode_unique": {
"name": "countries_isoCode_unique",
"nullsNotDistinct": false,
"columns": [
"iso_code"
]
"columns": ["iso_code"]
}
},
"policies": {},
Expand Down Expand Up @@ -360,12 +354,8 @@
"name": "customisations_user_id_users_id_fk",
"tableFrom": "customisations",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -524,25 +514,17 @@
"name": "feature_request_likes_user_id_users_id_fk",
"tableFrom": "feature_request_likes",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
},
"feature_request_likes_feature_request_id_feature_requests_id_fk": {
"name": "feature_request_likes_feature_request_id_feature_requests_id_fk",
"tableFrom": "feature_request_likes",
"tableTo": "feature_requests",
"columnsFrom": [
"feature_request_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["feature_request_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -626,12 +608,8 @@
"name": "feature_requests_user_id_users_id_fk",
"tableFrom": "feature_requests",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -763,9 +741,7 @@
"file_extraction_cache_file_hash_unique": {
"name": "file_extraction_cache_file_hash_unique",
"nullsNotDistinct": false,
"columns": [
"file_hash"
]
"columns": ["file_hash"]
}
},
"policies": {},
Expand Down Expand Up @@ -862,12 +838,8 @@
"name": "images_prompt_id_users_id_fk",
"tableFrom": "images",
"tableTo": "users",
"columnsFrom": [
"prompt_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["prompt_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand All @@ -877,16 +849,12 @@
"images_cloudinaryPublicId_unique": {
"name": "images_cloudinaryPublicId_unique",
"nullsNotDistinct": false,
"columns": [
"cloudinary_public_id"
]
"columns": ["cloudinary_public_id"]
},
"images_url_unique": {
"name": "images_url_unique",
"nullsNotDistinct": false,
"columns": [
"url"
]
"columns": ["url"]
}
},
"policies": {},
Expand Down Expand Up @@ -1024,12 +992,8 @@
"name": "interviews_job_id_jobs_id_fk",
"tableFrom": "interviews",
"tableTo": "jobs",
"columnsFrom": [
"job_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["job_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -1150,12 +1114,8 @@
"name": "invitations_organization_id_organizations_id_fk",
"tableFrom": "invitations",
"tableTo": "organizations",
"columnsFrom": [
"organization_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["organization_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -1309,12 +1269,8 @@
"name": "job_descriptions_job_id_jobs_id_fk",
"tableFrom": "job_descriptions",
"tableTo": "jobs",
"columnsFrom": [
"job_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["job_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -1421,12 +1377,8 @@
"name": "jobs_user_id_users_id_fk",
"tableFrom": "jobs",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -1551,25 +1503,17 @@
"name": "organization_members_organization_id_organizations_id_fk",
"tableFrom": "organization_members",
"tableTo": "organizations",
"columnsFrom": [
"organization_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["organization_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
},
"organization_members_user_id_users_id_fk": {
"name": "organization_members_user_id_users_id_fk",
"tableFrom": "organization_members",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -1766,12 +1710,8 @@
"name": "page_settings_report_id_reports_id_fk",
"tableFrom": "page_settings",
"tableTo": "reports",
"columnsFrom": [
"report_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["report_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -1861,12 +1801,8 @@
"name": "question_analysis_report_id_reports_id_fk",
"tableFrom": "question_analysis",
"tableTo": "reports",
"columnsFrom": [
"report_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["report_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -2081,12 +2017,8 @@
"name": "reports_interview_id_interviews_id_fk",
"tableFrom": "reports",
"tableTo": "interviews",
"columnsFrom": [
"interview_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["interview_id"],
"columnsTo": ["id"],
"onDelete": "cascade",
"onUpdate": "cascade"
}
Expand Down Expand Up @@ -2236,12 +2168,8 @@
"name": "reviews_user_id_users_id_fk",
"tableFrom": "reviews",
"tableTo": "users",
"columnsFrom": [
"user_id"
],
"columnsTo": [
"id"
],
"columnsFrom": ["user_id"],
"columnsTo": ["id"],
"onDelete": "no action",
"onUpdate": "no action"
}
Expand Down Expand Up @@ -2483,16 +2411,12 @@
"users_username_unique": {
"name": "users_username_unique",
"nullsNotDistinct": false,
"columns": [
"username"
]
"columns": ["username"]
},
"users_email_unique": {
"name": "users_email_unique",
"nullsNotDistinct": false,
"columns": [
"email"
]
"columns": ["email"]
}
},
"policies": {},
Expand All @@ -2504,13 +2428,7 @@
"public.feature_request_status": {
"name": "feature_request_status",
"schema": "public",
"values": [
"submitted",
"triaged",
"in_progress",
"completed",
"declined"
]
"values": ["submitted", "triaged", "in_progress", "completed", "declined"]
},
"public.interview_type": {
"name": "interview_type",
Expand All @@ -2528,40 +2446,22 @@
"public.invitation_status": {
"name": "invitation_status",
"schema": "public",
"values": [
"pending",
"accepted",
"rejected",
"expired",
"revoked"
]
"values": ["pending", "accepted", "rejected", "expired", "revoked"]
},
"public.margin_size": {
"name": "margin_size",
"schema": "public",
"values": [
"Normal",
"Narrow",
"Wide"
]
"values": ["Normal", "Narrow", "Wide"]
},
"public.paper_size": {
"name": "paper_size",
"schema": "public",
"values": [
"A4",
"Letter",
"Legal"
]
"values": ["A4", "Letter", "Legal"]
},
"public.role": {
"name": "role",
"schema": "public",
"values": [
"user",
"admin",
"recruiter"
]
"values": ["user", "admin", "recruiter"]
}
},
"schemas": {},
Expand All @@ -2574,4 +2474,4 @@
"schemas": {},
"tables": {}
}
}
}
2 changes: 1 addition & 1 deletion db/migrations/meta/_journal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@
"breakpoints": true
}
]
}
}
5 changes: 1 addition & 4 deletions functions/generate-missing-audio/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ export const handler = Sentry.wrapHandler(async () => {
for (const report of reportsToProcess) {
// Skip if interview doesn't have Hume chat ID (shouldn't happen for completed interviews)
if (!report.interview.humeChatId) {
logger.warn(
{ reportId: report.id },
"Skipping audio reconstruction - missing humeChatId"
);
logger.warn({ reportId: report.id }, "Skipping audio reconstruction - missing humeChatId");
continue;
}

Expand Down
Loading
Loading