chore(deps): update dtolnay/rust-toolchain requirement to 29eef336d9b2848a0b548edc03f92a220660cdb8#3
Closed
dependabot[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/ci.yml">
<violation number="1" location=".github/workflows/ci.yml:292">
P2: Bumping the toolchain in the `msrv` job without updating either the `Cargo.toml` `rust-version` field or the job name means the CI no longer validates the declared MSRV. The job is supposed to catch regressions against the minimum supported version, but now tests against 1.100 while Cargo.toml still says 1.88. Either revert this line (keep `@1.88`) if the MSRV stays at 1.88, or update `Cargo.toml` and the job name to 1.100 if the MSRV is being intentionally bumped.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - uses: dtolnay/rust-toolchain@1.88 | ||
| - uses: dtolnay/rust-toolchain@1.100 |
There was a problem hiding this comment.
P2: Bumping the toolchain in the msrv job without updating either the Cargo.toml rust-version field or the job name means the CI no longer validates the declared MSRV. The job is supposed to catch regressions against the minimum supported version, but now tests against 1.100 while Cargo.toml still says 1.88. Either revert this line (keep @1.88) if the MSRV stays at 1.88, or update Cargo.toml and the job name to 1.100 if the MSRV is being intentionally bumped.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/ci.yml, line 292:
<comment>Bumping the toolchain in the `msrv` job without updating either the `Cargo.toml` `rust-version` field or the job name means the CI no longer validates the declared MSRV. The job is supposed to catch regressions against the minimum supported version, but now tests against 1.100 while Cargo.toml still says 1.88. Either revert this line (keep `@1.88`) if the MSRV stays at 1.88, or update `Cargo.toml` and the job name to 1.100 if the MSRV is being intentionally bumped.</comment>
<file context>
@@ -289,7 +289,7 @@ jobs:
steps:
- uses: actions/checkout@v6
- - uses: dtolnay/rust-toolchain@1.88
+ - uses: dtolnay/rust-toolchain@1.100
- uses: Swatinem/rust-cache@v2
- run: cargo check --workspace --locked
</file context>
0059680 to
8b5722e
Compare
8b5722e to
216abc9
Compare
216abc9 to
75b47d7
Compare
75b47d7 to
1c74c34
Compare
1c74c34 to
7a3d918
Compare
7a3d918 to
056898e
Compare
056898e to
4645e2f
Compare
…2848a0b548edc03f92a220660cdb8 Updates the requirements on [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) to permit the latest version. - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](https://github.com/dtolnay/rust-toolchain/commits/29eef336d9b2848a0b548edc03f92a220660cdb8) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-version: '1.100' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
4645e2f to
7722b2f
Compare
Author
|
Superseded by #15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on dtolnay/rust-toolchain to permit the latest version.
Commits