Fix prepare binary data #1170
Merged
Fix prepare binary data #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates to a Vitess branch still on v21 where we now have a fix that ensures we don't mark all values as binary, which breaks bind vars. This fix is also present on v22 already, but we can't update to that yet until we have the full and entire fleet on at least v22. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
ayrton
approved these changes
Dec 9, 2025
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to a Vitess branch still on v21 where we now have a fix that ensures we don't mark all values as binary, which breaks bind vars.
This fix is also present on v22 already, but we can't update to that yet until we have the full and entire fleet on at least v22.
Fixes #1109