fix(discovery): drop SecretTargetAttachment discovery and the $LATEST version pseudo-entry - #183
Merged
Merged
Conversation
… version pseudo-entry CloudControl's SecretTargetAttachment list returns every secret in the account rather than actual attachments: the type is an action performed on a secret rather than a cloud object with its own inventory, so there is nothing to enumerate and reads of the listed ids fail. In any account with secrets that failed a discovery sync command on every cycle. The type goes back to discoverable = false, with the reason recorded inline; it remains fully declarable and manageable. CloudControl's Lambda version list includes the $LATEST pseudo-version, which is not a published version and whose read always fails. This was masked while the list post-filter dropped ARN-form results and surfaced once that was fixed. The generic list path now skips it, the same way AWS-managed policies and reserved aliases are skipped.
Neither SecretTargetAttachment discovery nor working Lambda version listing ever shipped in a release, so the attachment type simply leaves the unreleased enablement list and the version pseudo-entry needs no fix note. What was released broken is version discovery silently finding nothing, which gets the honest entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discoverable = falseonAWS::SecretsManager::SecretTargetAttachment, with the reason recorded inline. CloudControl's list handler returns every secret in the account rather than actual attachments: the type is an action performed on a secret, not a cloud object with an inventory, so there is nothing to enumerate and reads of the listed ids fail. In any account holding secrets this failed a discovery sync command on every cycle. A custom list is not a viable alternative: the only signal that a secret carries an attachment lives inside the secret's value, which discovery must not read. The type remains fully declarable and manageable.$LATESTpseudo-version fromAWS::Lambda::Versiondiscovery at list time (same mechanism as the AWS-managed policy and reserved alias exclusions). CloudControl's version list includes$LATEST, but it is not a published version and reading it always fails; this was previously masked by the list post-filter dropping ARN-form results and surfaced once that was fixed. Published versions keep discovering.Verification
make build,make verify-schema,make test-unit,make lintall pass.$LATEST-suffixed ids). Targeted conformance forlambda-versionandlambda-version-refdispatched from this branch; results will be linked in a comment. The attachment type has no conformance fixture; its discovery test returns to skipping, as before the flag flip.