docs+ci: close out wave 1 — matrix entries, README rows, changelog - #134
Merged
Conversation
The 25 resource types from PRs #126, #127 and #128 landed on main with no ongoing test coverage and no documentation. Their pull-request conformance runs proved them once, but nothing guarded them afterwards: none of their fixtures were in the curated matrix, so neither main nor nightly exercised any of them. Matrix: adds the 15 fixtures that passed CRUD *and* discovery on their own PR, which is the bar this file asks for - static-site, virtual-wan, vpn-site, bastion-host and all eleven cosmos-*. 113 active entries becomes 128. Ten fixtures stay out, each with its reason recorded inline: - app-service-plan, web-app, function-app, web-app-slot - the subscription has a dedicated-VM quota of 0 and an App Service plan of any sku runs on dedicated VMs. Verified against both B1 and F1, refused identically. - app-service-certificate, custom-hostname-binding - need a real verified custom domain. - virtual-hub - passes locally end to end (68m50s) but its CRUD phase measures ~59 min, longer than the OIDC client assertion stays valid, so the run dies on AADSTS700024 in the final phase. A credential-lifetime limit, not a plugin bug. - vpn-gateway, virtual-network-gateway, virtual-network-gateway-connection - 60-90 min lifecycles, past the job's timeout-minutes: 120. virtual-hub also joins conformance-pr-skip.txt. It was excluded from the matrix but not from PR scope, so a later PR touching its fixture would have spent an hour to fail on the same expired assertion. README: the resource table was 148 rows against 173 registered types. Adds the 25 missing rows, re-sorted; the table and the schemas now agree exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 25 resource types from #126, #127 and #128 are on
mainwith no ongoing test coverage and no documentation..github/conformance-matrix.txt, so neither push-to-main nor nightly exercised any of them. Their PR runs proved them once; nothing guarded them afterwards.Matrix — 113 → 128 active entries
Adds the 15 fixtures that passed CRUD and discovery on their own PR, which is the bar this file already asks for:
static-site·virtual-wan·vpn-site·bastion-host· all 11cosmos-*Ten stay out, each with its reason recorded inline:
app-service-plan,web-app,function-app,web-app-slotapp-service-certificate,custom-hostname-bindingvirtual-hubAADSTS700024in the final phasevpn-gateway,virtual-network-gateway,virtual-network-gateway-connectiontimeout-minutes: 120Note
virtual-hubis not a plugin bug —VirtualHub.Deletewaits for the hub router correctly (ARM refusesDeleteVirtualHubwhileroutingStateisProvisioning, ~11 min past the create LRO reportingSucceeded). It's a credential-lifetime limit. Re-add once CI can refresh auth mid-phase.Also:
virtual-hubadded toconformance-pr-skip.txtIt was excluded from the matrix but not from PR scope, so the next PR touching its fixture would have spent an hour to fail on the same expired assertion. Verified matrix and skip list have zero overlap (the two files are asserted disjoint by
conformance-scope.sh).README — 148 → 173 rows
Derived the gap from the schemas rather than by hand, so it catches anything I'd have missed. Added the 25 missing rows and re-sorted; the table and the registered types now agree exactly, and there are no stale rows.
Verification
Not in this PR
Two blockers that need people, not code:
virtual-huband any future >45-minute fixtureBoth are recorded in the matrix comments with the exact removal condition.