chore(manifest): never reap cloud targets - #199
Closed
JeroenSoeters wants to merge 1 commit into
Closed
Conversation
A cloud provider region cannot be deleted out of band, so reaping, which exists for targets whose backing infrastructure can go away, must never apply to this plugin's targets. Declare NeverReap as the manifest default; an explicit per-target reaping still wins. Takes effect once the agent wires manifest reaping defaults into target admission.
Contributor
Author
|
Superseded: the reaping default is moving out of the plugin manifest (which is package metadata) onto a class-level annotation on the target Config class, next to the ConfigFieldHint mutability annotations — it rides ConfigSchema to admission with no agent-side manifest read. The manifest field is being removed from formae core in the rework of platform-engineering-labs/formae#756; the annotation replacement lands once the core release carrying formae.ConfigHint is published and this plugin's schema pin moves to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares
NeverReapas this plugin's manifest default reaping behaviour: a cloud provider region cannot be deleted out of band, so reaping — which exists for targets whose backing infrastructure can go away — must never apply to its targets. An explicit per-target reaping still wins. Takes effect with platform-engineering-labs/formae#756, which wires manifest reaping defaults into target admission.