test(blackbox): assert cross-stack slots against the model like any other slot - #658
Merged
Merged
Conversation
…ther slot Cross-stack slots were excluded from both directions of the model-vs-inventory check, and a failed or canceled command's unmentioned cross-stack slots were never reverted to their snapshots, on the grounds that their persistence behavior was not derivable from the command response. That left two of the twelve slots per consumer stack entirely unasserted. The claimed nondeterminism does not reproduce on the deterministic harness: cross-stack resource updates carry per-resource terminal states like any others, and with the drift-tolerance mechanism gone and sync observation working, repeated full-chaos runs hold green with the exclusions removed. Delete all three skips and pin the restored coverage with tests for the forward check, the unexpected-inventory check, and the unmentioned-slot revert.
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cross-stack slots were excluded from both directions of
CheckModelVsInventory, andcorrectModelFromCommandOutcomestep 2 never reverted a failed/canceled command's unmentioned cross-stack slots, on the stated grounds that "the command response alone can't tell us whether they were persisted". That left 2 of the 12 slots per consumer stack entirely unasserted — the largest remaining strictness hole after the drift-determinism rewrite (#656).What
The claimed nondeterminism does not reproduce on the deterministic harness. Cross-stack resource updates carry per-resource terminal states like any other slot (visible in every drained command's updates), and the conditions that plausibly produced the original flakiness — silently no-op sync settles, the drift exemption retirement, verbatim patch predictions — were all fixed in #656/#657. With all three exclusions removed,
TestProperty_FullChaosholds green over four consecutive 25-check runs (100 iterations) locally.CheckModelVsInventoryand the one incorrectModelFromCommandOutcomestep 2.If a genuine cross-stack nondeterminism exists after all, this suite will now find and report it instead of silently skipping it — which is the point.
Fixes the gap tracked in PLA-713 (internal).