test(blackbox): skip a CloudCreate that reuses a tracked native id - #673
Merged
Conversation
The generator draws out-of-band native ids from a small pool, so an id can repeat within a sequence. Re-creating a cloud entry the model already tracks as present is an out-of-band modification of that resource, not a creation: discovery only ingests native ids inventory does not know, so the fresh CloudProperties expectation armed by the repeated create can never converge through the discovery path and the trigger exhausts its retries. Out-of-band modification of unmanaged resources is OpCloudModify's surface; the repeated create is skipped. Also dump the unconverged expectation violations when a discovery trigger gives up, so the next such failure names the offending rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
TestProperty_FullChaosfailure observed on #668's CI:discovery did not ingest — expected unmanaged resources were not ingested after 3 attempts.The generator draws out-of-band native ids from a small pool, so an id can repeat within a sequence. The failing shape:
CloudCreate cloud-4→ discovery ingests it →CloudCreate cloud-4again with freshly drawn properties. The repeated create overwrites the cloud entry and arms freshCloudPropertiesexpectations in the model — but discovery only ingests native ids inventory does not know, so it can never converge those expectations; the trigger exhausts its retries and fails the run. Re-creating a tracked entry is semantically an out-of-band modification, which isOpCloudModify's surface (absorbed by sync, with its own modeling); the repeated create is now skipped.Also dumps the unconverged expectation violations when a discovery trigger gives up, so the next such failure names the offending rows instead of requiring log archaeology.
Harness-level regression test covers the shape (create → ingest → re-create skipped → discovery still converges). Fourth in the series of pre-existing seed-dependent gaps surfaced by the strict suite (#670, #672 before it); blocks #668's CI.