feat(provx): mark connect artifacts formae-owned - #7
Merged
Conversation
…them alone The role and provider connect creates in a customer account are discovered like any other resource and land unmanaged, where nothing stops someone importing them and reconciling them away. Doing that to the provider severs formae's access to the account. Write a single marker, formae-owned=true, that the cloud plugins' discovery filters key on. It answers one question, whether formae created the thing, and deliberately not who may delete it: that stays with the formae-ai:owner and formae-ai:subject provenance tags, whose values the delete gate reads. The key avoids a colon so the same spelling is legal on all three clouds. GCP label keys admit only lowercase letters, digits, underscores and hyphens, which is also why azure moves from formae:owned to the shared key. Tagging is best-effort on both paths, and the provider is tagged through its own request rather than the create's Tags field. CreateOpenIDConnectProvider has never needed iam:TagOpenIDConnectProvider, so requiring it there would break connect for callers it works for today; degrading to an untagged provider leaves them exactly where they already are. The role has no such exposure, since AWS already requires iam:TagRole to pass Tags to CreateRole, but it is treated the same way for consistency. Both markers are also written on the converge path, which is what carries them to the roles and providers already standing in accounts connected before this existed. Re-running connect is now the migration.
JeroenSoeters
deleted the
jeroensoeters/pla-744-tag-connect-artifacts
branch
September 5, 2026 02:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The role and OIDC provider connect creates in a customer account are discovered like any other resource and land unmanaged, where nothing stops someone importing them and reconciling them away. Doing that to the provider severs formae's own access to the account.
Write a single marker,
formae-owned=true, that the cloud plugins' discovery filters key on. It answers one question, whether formae created the thing, and deliberately not who may delete it: that stays with theformae-ai:owner/formae-ai:subjectprovenance tags whose values the delete gate reads.The key avoids a colon so the same spelling is legal on all three clouds. GCP label keys admit only lowercase letters, digits, underscores and hyphens, which is also why azure moves from
formae:ownedto the shared key.Tagging is best-effort, and the provider is tagged through its own request rather than the create's
Tagsfield.CreateOpenIDConnectProviderhas never needediam:TagOpenIDConnectProvider, so requiring it there would break connect for callers it works for today; degrading to an untagged provider leaves them exactly where they already are. The role has no such exposure, since AWS already requiresiam:TagRoleto passTagstoCreateRole, but it is treated the same way for consistency.Both markers are also written on the converge path. That is what carries them to the roles and providers already standing in accounts connected before this existed, so re-running connect is the migration rather than a one-off script.
Azure needs no convergence work:
CreateOrUpdateon the resource group and identity is already an upsert carryingTags.