Skip to content

Switch to retentive outputs - #38

Open
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-retentive-outputs
Open

Switch to retentive outputs#38
mzueva wants to merge 1 commit into
mainfrom
mzueva/use-retentive-outputs

Conversation

@mzueva

@mzueva mzueva commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant change in the output handling mechanism within the model package, transitioning to a 'retentive output' approach. Concurrently, it incorporates a comprehensive set of dependency updates across various internal @platforma-sdk and @milaboratories packages, ensuring the project leverages the latest versions and their associated improvements or fixes.

Highlights

  • Core Logic Change: The model/src/index.ts file has been updated to switch from outputWithStatus to retentiveOutputWithStatus for the 'stats' output. This indicates a change in how outputs are handled, likely to ensure data retention across block executions.
  • Dependency Updates: Numerous @platforma-sdk and @milaboratories packages have been updated to their latest patch or minor versions across pnpm-lock.yaml and pnpm-workspace.yaml. This includes updates for block-tools, model, tengo-builder, test, ui-vue, and various pl- prefixed packages.
  • Changelog Entry: A new changeset file (.changeset/true-jeans-wish.md) has been added, documenting the switch to retentive outputs for the @platforma-open/milaboratories.import-vdj.model package.
Changelog
  • .changeset/true-jeans-wish.md
    • Added a new changeset file to document the 'Switch to retentive outputs' for the @platforma-open/milaboratories.import-vdj.model package.
  • model/src/index.ts
    • Replaced outputWithStatus('stats', ...) with retentiveOutputWithStatus('stats', ...) to enable retentive behavior for the 'stats' output.
  • pnpm-lock.yaml
    • Updated @platforma-sdk/block-tools from 2.6.35 to 2.6.37.
    • Updated @platforma-sdk/model from 1.53.2 to 1.53.4.
    • Updated @platforma-sdk/tengo-builder from 2.4.12 to 2.4.13.
    • Updated @platforma-sdk/test from 1.53.2 to 1.53.4.
    • Updated @platforma-sdk/ui-vue from 1.53.2 to 1.53.4.
    • Updated @milaboratories/pf-driver from 1.0.30 to 1.0.32.
    • Updated @milaboratories/pl-client from 2.16.24 to 2.16.25.
    • Updated @milaboratories/pl-deployments from 2.15.5 to 2.15.6.
    • Updated @milaboratories/pl-drivers from 1.11.42 to 1.11.43.
    • Updated @milaboratories/pl-errors from 1.1.56 to 1.1.57.
    • Updated @milaboratories/pl-middle-layer from 1.46.10 to 1.46.12.
    • Updated @milaboratories/pl-model-backend from 1.1.41 to 1.1.42.
    • Updated @milaboratories/pl-model-common from 1.24.1 to 1.24.2.
    • Updated @milaboratories/pl-model-middle-layer from 1.10.4 to 1.10.6.
    • Updated @milaboratories/pl-tree from 1.8.32 to 1.8.33.
    • Updated @milaboratories/ptabler-expression-js from 1.1.11 to 1.1.12.
    • Updated @milaboratories/uikit from 2.10.10 to 2.10.12.
    • Updated @platforma-open/milaboratories.software-ptabler.schema from 1.13.4 to 1.13.5.
    • Corrected a typo in the deprecation message for tar from 'exhorbitant' to 'exorbitant'.
  • pnpm-workspace.yaml
    • Updated @platforma-sdk/model version in catalog from 1.53.2 to 1.53.4.
    • Updated @platforma-sdk/ui-vue version in catalog from 1.53.2 to 1.53.4.
    • Updated @platforma-sdk/block-tools version in catalog from 2.6.35 to 2.6.37.
    • Updated @platforma-sdk/test version in catalog from 1.53.2 to 1.53.4.
    • Updated @platforma-sdk/tengo-builder version in catalog from 2.4.12 to 2.4.13.
    • Updated @platforma-sdk/package-builder version in catalog from ^3.10.7 to ^3.11.0.
Activity
  • The pull request was opened by mzueva.
  • No additional human activity (comments, reviews) has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request switches the 'stats' output to be retentive, which should improve performance by caching the output. The change is consistent with other outputs in the model. The PR also includes updates to several dependencies. I've identified two transitive dependencies, glob and tar, that are marked as deprecated due to security vulnerabilities. It is highly recommended to update these to their latest non-vulnerable versions.

Comment thread pnpm-lock.yaml

glob@10.5.0:
resolution: {integrity: sha512-DfXN8DfhJ7NH3Oe7cFmu3NCu1wKbkReJ8TorzSAFbSKrlNaQSKfIzqYqVY8zlbs2NLBbWpRiU52GX2PbaBVNkg==}
deprecated: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The transitive dependency glob is marked as deprecated, with the message indicating security vulnerabilities in older versions. This poses a potential security risk and should be addressed by updating the parent dependency to resolve to a non-vulnerable version of glob.

Comment thread pnpm-lock.yaml
resolution: {integrity: sha512-7NyxrTE4Anh8km8iEy7o0QYPs+0JKBTj5ZaqHg6B39erLg0qYXN3BijtShwbsNSvQ+LN75+KV+C4QR/f6Gwnpg==}
engines: {node: '>=18'}
deprecated: Old versions of tar are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exhorbitant rates) by contacting i@izs.me
deprecated: Old versions of tar are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The transitive dependency tar is marked as deprecated, with the message indicating security vulnerabilities in older versions. This poses a potential security risk and should be addressed by updating the parent dependency to resolve to a non-vulnerable version of tar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant