Milab-6720: fix tsv separator, fix anarci version - #48
Merged
Conversation
Loading a TSV failed on server deployments with `TypeError: "delimiter" must be a 1-character string` while the same file loaded on a desktop backend. The block passed a real tab as an argv element. Desktop runners exec argv directly, so the tab arrived intact; the k8s and google-batch runners serialise the command with Go's %q and re-run it through `sh -c`, where the tab has already become the two characters \ and t and stays that way. Prerun now sends "tab" or "comma" and main.py maps the name back to the character, so only plain words cross the runner boundary. A separator that still arrives malformed fails with a message naming the accepted values rather than a TypeError.
pl-pkg build ignores PL_BUILD_CHANNEL/VARIANT/LOCATION and defaults docker image builds to CI-only, so a local build:dev-remote produced binary-only descriptors. A block built that way cannot run on a k8s deployment, which launches containers exclusively. block-tools software build honours those variables — variant all builds the images, location remote pushes them — matching tcr-disco and the other already-migrated software packages. PL_PKG_DEV drops out of the root scripts and turbo.json, since PL_BUILD_LOCATION now carries its meaning.
Region annotation failed on k8s with "ANARCI: not found" (127). The conda image exposes its env only via ENTRYPOINT ["micromamba", "run", "--prefix", "/conda-env"], a k8s pod spec overrides the image entrypoint, and every software-anarci up to 1.0.0 records docker.entrypoint: [] — so nothing re-applied the wrapper. 1.0.1 was built by a package-builder that reads .Config.Entrypoint back from the image, so the runner can reconstruct it. ^0.0.3 is exact for a 0.0.x range, so the pin never picked the fix up.
Part of the canonical software-module shape that block-tools structure applies
(N("type","module")), and what every already-migrated software package carries.
Missed in the block-tools build migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR fixes server-side TSV profiling, restores ANARCI execution in containerized deployments, and migrates three companion software packages to environment-aware builds.
tabandcomma, which the profiler resolves to characters locally.block-tools software buildso local and remote variants include the expected container artifacts.PL_BUILD_LOCATION; it replaces the legacyPL_PKG_DEVrole in root scripts and Turbo cache inputs.shxfile operations.Confidence Score: 5/5
The PR appears safe to merge; the changed separator, software-build, and ANARCI dependency paths remain aligned with their current callers and runtime contracts.
The profiler receives a delimiter matching every supported prepared-file representation, the software packages use the repository’s environment-aware build flow, and no concrete incompatibility was found in the ANARCI upgrade.
Important Files Changed
commaortabaccording to the prepared file extension, keeping CSV, TSV, and converted XLSX profiling aligned.PL_PKG_DEVsettings from root test and local-build commands in favor of the existingPL_BUILD_*contract.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Input[CSV, TSV, or XLSX] --> Prepare[Prepare readable table] Prepare --> Select[Choose named separator] Select --> Profile[Resolve name and profile columns] Profile --> Mapping[Mapping setup] Mapping --> Import[Import records] Import --> ANARCI[ANARCI 1.0.1 with recorded entrypoint] ANARCI --> Regions[FR and CDR annotation] BuildEnv[PL_BUILD variant and location] --> BlockTools[Block Tools software build] BlockTools --> Profile BlockTools --> ANARCIReviews (1): Last reviewed commit: "MILAB-6720: move to software-anarci 1.0...." | Re-trigger Greptile
Context used (5)