fix: fail over from a hung bootstrap broker during InitProducerId#318
Merged
ShogunPanda merged 2 commits intoJun 16, 2026
Merged
Conversation
#initIdempotentProducer and #findCoordinator never passed `attempt` to kGetBootstrapConnection, so its retry-rotation branch stayed dead and an idempotent producer kept retrying InitProducerId against a reachable-but-hung bootstrap broker instead of failing over to known-healthy brokers. Thread `attempt` through both paths. Fixes platformatic#317. Signed-off-by: Andrew Houghton <aah@roarmouse.org>
ShogunPanda
requested changes
Jun 15, 2026
ShogunPanda
left a comment
ShogunPanda
left a comment
Contributor
There was a problem hiding this comment.
A little nit but the rest LGTM!
aahoughton
added a commit
to aahoughton/kafka
that referenced
this pull request
Jun 15, 2026
Replace hand-rolled getFirstAvailable override with the existing mock helper. Addresses review feedback on platformatic#318.
Replace hand-rolled getFirstAvailable override with the existing mock helper. Addresses review feedback on platformatic#318. Signed-off-by: Andrew Houghton <aah@roarmouse.org>
aahoughton
force-pushed
the
fix/issue-317-init-producer-id-failover
branch
from
87dfc55 to
5ee3904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#initIdempotentProducer and #findCoordinator never passed
attemptto kGetBootstrapConnection, so its retry-rotation branch stayed dead and an idempotent producer kept retrying InitProducerId against a reachable-but-hung bootstrap broker instead of failing over to known-healthy brokers.Thread
attemptthrough both paths. Fixes #317.