fix: call deduplicateCallback on topics deletion error#323
Merged
ShogunPanda merged 1 commit intoJun 22, 2026
Merged
Conversation
Signed-off-by: Krzysztof Jamrog <krzysztof.jamrog@lokalise.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the error path of
Admin#deleteTopicsto calldeduplicateCallbackinstead of the rawcallback.Why
On error,
#deleteTopicsinvoked the outercallbackdirectly and never calleddeduplicateCallback. BecausekPerformDeduplicatedonly clears its in-flight entry (and flushes queued callers) when that completion callback fires, a faileddeleteTopicsleft a stale entry in the deduplication cache. As a result, any subsequentdeleteTopicsfor the same topic set on the sameAdmininstance would be queued forever and never resolve — and concurrent duplicate callers would hang on the first failure too.A common trigger is deleting a non-existent topic (e.g. test cleanup): the first call errors and poisons the cache, so every later call hangs.
This aligns
#deleteTopicswith#createTopics, which already callsdeduplicateCallback(new MultipleErrors(...))on error.Consequences
MultipleErrors('Deleting topics failed.', [error])); existing tests still pass.Test
Adds a regression test asserting that a second
deleteTopicsfor the same topics still rejects (rather than hangs) after a prior failure.