Skip to content

fix: remove duplicate port directives from default config #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jajera merged 1 commit into from
Aug 17, 2026
Merged

fix: remove duplicate port directives from default config #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Smoke

on:
pull_request:
branches:
- main
workflow_dispatch:

jobs:
startup:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Build image
run: docker build -t ringserver:smoke .

- name: Container starts without port bind error
run: |
set -euo pipefail
log="$(timeout 5 docker run --rm --name ringserver-smoke ringserver:smoke 2>&1 || true)"
echo "$log"
echo "$log" | grep -q 'Ring initialized'
! echo "$log" | grep -q 'Address already in use'
4 changes: 1 addition & 3 deletions config/ringserver.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Default public-edge listen: SeedLink on 18000, DataLink on 16000.
# Default listen ports come from earthscope/ringserver (18000, 16000).
# Env vars (RS_*) override this file. See ringserver -C.

RingDirectory /data/ring
SeedLinkPort 18000
DataLinkPort 16000
Loading