This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Feature/db implementation#39
Open
jonattan-infante wants to merge 11 commits into
Open
Conversation
Contributor
|
Can we please link the issue with the PR? 😁 |
Author
|
@omarefg The link of the PR is https://github.com/platzily/platzily-monolith/issues/36 |
Contributor
|
Perfect, but what I do not see es the issue related to the PR. It's created? |
omarefg
suggested changes
Aug 14, 2021
Contributor
|
|
Contributor
|
There are conflicts with the package.json. |
gh0stl1m
suggested changes
Aug 14, 2021
jonattan-infante
commented
Sep 7, 2021
omarefg
suggested changes
Sep 12, 2021
omarefg
previously approved these changes
Sep 29, 2021
gh0stl1m
previously approved these changes
Oct 9, 2021
Co-authored-by: Santiago Sánchez Taborda <santiago.sanchez.t@gmail.com>
jonattan-infante
dismissed stale reviews from gh0stl1m and omarefg
via
43aaf0d
omarefg
approved these changes
Nov 10, 2021
edanfesi
suggested changes
Nov 16, 2021
| @@ -0,0 +1,6 @@ | |||
| # `mariadb-connection-module` | |||
|
|
|||
| > TODO: description | |||
There was a problem hiding this comment.
We have to add some explanation about this module, like the environments that the module use and so on.
avanegasp
added
the
carry-over-4
edanfesi
added
the
carry-over-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description